Skip to content

Prevent review monitor crashes when dispatching Codex tasks#63

Merged
NagyVikt merged 1 commit intomainfrom
agent/codex/lajos-edix-hu-review-bot-watch-flow-fix
Apr 13, 2026
Merged

Prevent review monitor crashes when dispatching Codex tasks#63
NagyVikt merged 1 commit intomainfrom
agent/codex/lajos-edix-hu-review-bot-watch-flow-fix

Conversation

@NagyVikt
Copy link
Copy Markdown
Collaborator

Automated by scripts/agent-branch-finish.sh (PR flow).

The watch loop was invoking codex-agent with positional task arguments plus '-- exec', which old codex-agent parsing treated as a stray '--' argument and broke Codex invocation.\n\nSwitch dispatch to explicit --task/--agent/--base flags so both old and new codex-agent implementations receive a clean 'codex exec <prompt>' call path.

Constraint: Must stay compatible with mixed codex-agent script versions across existing worktrees

Rejected: Require users to rerun gx setup first | breaks ongoing monitor sessions

Confidence: high

Scope-risk: narrow

Reversibility: clean

Directive: Keep watch-loop invocation style option-based when passing codex subcommands

Tested: node --test test/install.test.js --test-name-pattern "review-bot-watch"

Tested: npm test

Tested: node --check bin/multiagent-safety.js

Tested: npm pack --dry-run
@NagyVikt NagyVikt merged commit 1996fad into main Apr 13, 2026
7 checks passed
@NagyVikt NagyVikt deleted the agent/codex/lajos-edix-hu-review-bot-watch-flow-fix branch April 13, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant